send http.route attribute in flask metric #2506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@GonzaloGuasch please sign the CLA |
|
@GonzaloGuasch please do all your commits from the same email that signed the CLA, see #2506 (comment) |
|
Changing the PR to draft until i resolve CLA certification with mi company! |
xrmx
reviewed
Jun 18, 2024
| @@ -47,6 +47,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Added | |||
|
|
|||
| - `opentelemetry-instrumentation-flask` Add http route to metric attributes | |||
| ([#2506](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2506)) | |||
| - | |||
emdneto
reviewed
Jun 18, 2024
| duration_histogram_old.record( | ||
| max(round(duration_s * 1000), 0), duration_attrs_old | ||
| ) | ||
| if duration_histogram_new: | ||
| duration_attrs_new = otel_wsgi._parse_duration_attrs( | ||
| attributes, _HTTPStabilityMode.HTTP | ||
| ) | ||
|
|
||
| if wrapped_app_environ.get(_ENVIRON_REQUEST_ROUTE_KEY, None): | ||
| duration_attrs_new[SpanAttributes.HTTP_ROUTE] = wrapped_app_environ.get(_ENVIRON_REQUEST_ROUTE_KEY) |
There was a problem hiding this comment.
Shouldn't we use the new semconv attribute here?
There was a problem hiding this comment.
What do you mean by new semconv? To change the variable?
It is mandatory to have the key value "http.route"
…zaloGuasch/opentelemetry-python-contrib into feature/flask-attr-in-metric
…zaloGuasch/opentelemetry-python-contrib into feature/flask-attr-in-metric
…zaloGuasch/opentelemetry-python-contrib into feature/flask-attr-in-metric
|
@GonzaloGuasch the CLA check is failing 😓 |
|
Closing this PR due to contract problems 😭. Continue in this new #PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taking up this closed PR, when sending metrics in the Flask instrumentation, the http.route attribute is added to them.
This attribute is super important in the use of metrics and will greatly improve the experience of using Flask. This change was tested locally.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
running: tox -e test-instrumentation-flask
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.